search

tonyalaribe / mybonways

View promos from stores around you
https://mybonways.com
0 stars 1 forks source link

why are you storing objects as null? #37

Closed tonyalaribe closed 7 years ago

tonyalaribe commented 7 years ago

Stop storing objects as null. Instead, if you want to clear an object, you store an empty object into it. eg NewUser = {}

Nulling objects brings in a lot of unpredictability and bugs. I keep telling you to read javascriupt the bad parts. screen shot 2017-07-11 at 8 40 02 am screen shot 2017-07-11 at 8 42 12 am screen shot 2017-07-11 at 8 42 19 am screen shot 2017-07-11 at 8 42 25 am

tonyalaribe commented 7 years ago

After signup, there is also no indication that the user was signup up successfully.

And its possible to have duplicated user accounts. And there is no allowance for account verification. Take cue from the merchant signup. Users should verify their accounts before login.

spankie commented 7 years ago

resolved

tonyalaribe commented 7 years ago

screen shot 2017-07-12 at 2 57 37 pm

Signup isnt working


Invalid Request
error inside of calling function
github.com/tonyalaribe/mybonways/vendor/github.com/markbates/pop.(*Connection).Transaction.func1
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/markbates/pop/connection.go:116
github.com/tonyalaribe/mybonways/vendor/github.com/markbates/pop.(*postgresql).Lock
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/markbates/pop/postgresql.go:150
github.com/tonyalaribe/mybonways/vendor/github.com/markbates/pop.(*Connection).Transaction
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/markbates/pop/connection.go:119
github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/middleware.glob..func1.1.1
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/middleware/pop_transaction.go:29
github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/middleware/csrf.glob..func1.1
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/middleware/csrf/csrf.go:56
github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/middleware.ParameterLogger.func1
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/middleware/param_logger.go:23
github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo.RequestLoggerFunc.func1
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/request_logger.go:48
github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo.(*App).PanicHandler.func1
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/errors.go:68
github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo.(*App).handlerToHandler.func1
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/handler.go:71
net/http.HandlerFunc.ServeHTTP
    /usr/local/opt/go/libexec/src/net/http/server.go:1942
github.com/tonyalaribe/mybonways/vendor/github.com/gorilla/mux.(*Router).ServeHTTP
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/gorilla/mux/mux.go:114
github.com/tonyalaribe/mybonways/vendor/github.com/markbates/refresh/refresh/web.ErrorChecker.func1
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/markbates/refresh/refresh/web/web.go:23
net/http.HandlerFunc.ServeHTTP
    /usr/local/opt/go/libexec/src/net/http/server.go:1942
github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo.(*App).ServeHTTP
    /Users/macbook/go/src/github.com/tonyalaribe/mybonways/vendor/github.com/gobuffalo/buffalo/app.go:40
net/http.serverHandler.ServeHTTP
    /usr/local/opt/go/libexec/src/net/http/server.go:2568
net/http.(*conn).serve
    /usr/local/opt/go/libexec/src/net/http/server.go:1825
runtime.goexit
    /usr/local/opt/go/libexec/src/runtime/asm_amd64.s:2197```
tonyalaribe commented 7 years ago

Seems ok.