search

tonybaloney / Pyjion

Pyjion - A JIT for Python based upon CoreCLR
https://www.trypyjion.com
MIT License
1.43k stars 59 forks source link

Further optimize getting a slice subscript when the values are dynamic #185

Open todo[bot] opened 3 years ago

todo[bot] commented 3 years ago

https://github.com/tonybaloney/Pyjion/blob/085ad55074ee883d66e5e38ea86fe8f42c99f5dc/src/pyjion/pycomp.cpp#L867-L871

This issue was generated by todo based on a TODO comment in 085ad55074ee883d66e5e38ea86fe8f42c99f5dc when #182 was merged. cc @tonybaloney.
tonybaloney commented 3 years ago

This actually makes the benchmark slower. I think its because its benchmarked against PyObject_GetAttr, which is heavily optimized by CPython's PGO profile