Open ArneBachmannDLR opened 2 years ago
I enjoyed the talk and checking out the tool!
I ran into some issues with Pandas treating lists differently than tuples (when using them as keys).
I also hit a lot of false positives with loop-invariant-statements
(unless I'm missing something).
I tried to simplify out an example of something it'd hit a false positive on:
keys = []
for record in ({'a': 4}, {'b': 8}):
keys.append(tuple(k for k in record if k in ('b', 'c')))
print(keys)
I think it was saying k in ('b', 'c')
was loop invariant.
Great project! I found at least one line of code that could be improved (moved loop to a dictionary expression); but I see, however, 99.5% false positives, e.g.:
loop-try-except-usage
can only be moved outside the loop, if the except clause contains abreak
. Otherwise I want to keep processing the looploop-invariant-statement
is usually not at all invariant but depends on a loop variableuse-tuple-over-list
is most often typed as aList[...]
and therefore cannot and should not hold a tuple, even if initiated empty