search

tonybaloney / wily

A Python application for tracking, reporting on timing and complexity in Python code
Apache License 2.0
1.2k stars 58 forks source link

Experiment: Convert .gitignore entries to radon ignore/exlude #214

Open devdanzin opened 1 year ago

devdanzin commented 1 year ago

This PR addresses a TODO in build.py: "Convert .gitignore to radon ignore patterns to make the build more efficient". However, timings show no difference in performance even with a lot of added Python files in ignored directories. That happens because radon is called only with modified files from given revisions as targets, so the build is already optimal in this sense.

This PR serves only to document this exploration. Leaving it open for a while in case we can identify a scenario it would help with.

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.52%. Comparing base (acf39d2) to head (7959156). Report is 17 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #214 +/- ## ========================================== + Coverage 95.46% 95.52% +0.05% ========================================== Files 26 26 Lines 1346 1364 +18 Branches 287 291 +4 ========================================== + Hits 1285 1303 +18 Misses 37 37 Partials 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tonybaloney commented 1 year ago

lmk when this is ready to review