search

tonybaloney / wily

A Python application for tracking, reporting on timing and complexity in Python code
Apache License 2.0
1.2k stars 58 forks source link

Log calls should all be lazy-formatted #219

Closed tonybaloney closed 1 year ago

tonybaloney commented 1 year ago

I've noticed that the logger.debug() calls throughout the codebase use f-strings.

This isn't ideal because it eagerly formats the message even when logging isn't in debug mode.

It should use % style messages with the arguments as parameters. There is a pylint check for this