search

tonycoco / heroku-buildpack-ember-cli

A Heroku Buildpack for Ember CLI Applications
MIT License
320 stars 121 forks source link

Set environment variable a Heroku config variable #1

Closed adriaandotcom closed 10 years ago

adriaandotcom commented 10 years ago

It would be nice to load the ember build environment from the Heroku config variables. So you can run staging, production and development.

# bin/compile
status "Building Ember CLI application production distribution"
node_modules/.bin/bower install --quiet | indent
node_modules/ember-cli/bin/ember build --environment production | indent
tonycoco commented 10 years ago

@harianus That is a great idea. I'll work on that now. Any suggestions to the standardized ENV var? We use ENV["EMBER_ENV"]

adriaandotcom commented 10 years ago

ENV["EMBER_ENV"] sounds good to me. When you choose ENV["ENV"] and you use it for other scripts as well, then you will have a problem when ember changes its environment names.

tonycoco commented 10 years ago

Yeah, agreed. I'll make that change ASAP.

amywilkie commented 10 years ago

Hi,

Just wondering when you think this change may be made?

tonycoco commented 10 years ago

Fixed in 73b6bac897dfc1580070be3ef459fcb1b1dce753.

amywilkie commented 10 years ago

Fixed in 73b6bac.

Champion ;)

adriaandotcom commented 10 years ago

Nice, thanks! Hopefully ember-cli will support custom environments soon: https://github.com/stefanpenner/ember-cli/issues/662