tonycoco / heroku-buildpack-ember-cli

A Heroku Buildpack for Ember CLI Applications
MIT License
321 stars 121 forks source link

Thoughts on supporting yarn as well as npm? #139

Closed steveklabnik closed 7 years ago

steveklabnik commented 7 years ago

I'm looking to move my projects to yarn. Is there any opposition to adding support for it in this buildpack? I'm willing to send a PR, but wanted to know if it's likely to be accepted or not.

tonycoco commented 7 years ago

Yes, for sure! Send the PR along and I'll merge asap.

tonycoco commented 7 years ago

Also, check out the official Heroku buildpack here: https://github.com/heroku/heroku-buildpack-emberjs – I've since deprecated this build pack in favor of it.

steveklabnik commented 7 years ago

Great!

I did see that you did that, but it seems that that one is also experimental, and we've been using this one in production for a while, so I'm still okay with this for now. No worries though!