Open suedunham opened 5 years ago
You haven't bungled anything -- I just haven't had a chance to try to get things working on Windows yet. I know there are a lot of folks who will want to run this on Windows so I will try to take a look soon.
Thanks, no worries. My team's off to an atrocious start anyway. PitchingNotFoundError
I've pushed changes as of b12b2c6c that at least get me to the point where I can download MLB games via the CLI. These changes include conditionally importing termios
and other UNIX-focused modules based on whether or not the platform is Windows. This breaks some GUI features (progress reporting of downloads) but Urwid doesn't work in Windows proper anyway (only via Cygwin) and getting things running Cygwin is going to take a lot of additional effort.
Windows people, please try this and let me know if it helps.
It now successfully completes the install and begins to run on Windows, but when I try to download a game there is an error. I opened a new issue.
Game download is working perfectly on Windows! I can select the resolution I want and all audio streams are present in the file.
Thanks for all your great work! All I need is download functionality so it's fine that the streaming GUI doesn't work on Windows.
I just installed this on a new Windows computer and I'm getting that "No module named 'termios'" error there. The setup seemed to work fine, I saw no errors, this is when trying to download a game.
I tried a download on my old computer and it is still working there. Is the fix that was implemented here still in place? If so it didn't seem to have taken effect when installing on this system for some reason.
I might have installed it differently back on the other computer? This time around I just followed the steps in the repo readme using Git for Windows. I feel like that's what I did before also, but it was so long ago I don't remember for sure.
Still having the same issue trying to make this work on my new computer - but now it no longer works on my old computer either (throwing some other error when I try to download) so I can't just download games over there anymore. Please help?
I'm trying to install on Windows 10, which reasonably enough doesn't seem to support the termios module. Trying to view a mlb game gave me the ModuleNotFoundError stemming from player.py to pty, to tty. Is there a workaround at this time, or have I bungled the installation somehow?