search

tonydisera / gene.iobio

An iobio app for examining gene variants
22 stars 4 forks source link

Data entry modal problems #423

Open AlistairNWard opened 8 years ago

AlistairNWard commented 8 years ago
  1. Open gene and select platinum data for a trio. Click load and all panels are displayed as expected.
  2. Go back to the Data modal.
  3. Click 'Single'. The variant and coverage panels for Mother and Father in the main gene window are cleared out. Nothing should happen until 'Load' is clicked.
  4. Click 'Trio'. While all the bam and vcf urls are still present, it appears that in reality they have been cleared out. 'Load' is greyed out because it doesn't actually know the URLs. If I reselect the BAM URLs and click 'Load', variants are called with Freebayes for Mother and Father, even though the vcf is specified in the modal.

Fixes:

  1. No action taken until 'Load' is clicked.
  2. Mother and Father URLs should not be cleared out when 'Single' is clicked. If we load a single, go back to the data and select trio, either the urls still need to be associated with the parents (preferable), or the fields need to be cleared out forcing reselection.

Add Selenium tests to check this functionality.

tonydisera commented 8 years ago

My 'bug fix' kicked us in the butt. I agree with your proposal.

AlistairNWard commented 8 years ago

Ha! Nielson will build some Selenium tests for this, but we'll stick to our new release and priority model, so this might sit on the to-do pile for a while!

AlistairNWard commented 7 years ago

Some of this is fixed - some isn't.

  1. Load Demo data
  2. Open files modal, select single, then Load
  3. Open files modal, select trio.

All fields are populated with the Platinum data, but Load cannot be selected. Reassign all the Platinum data for the parents and Load becomes active again.