search

tonydspaniard / Yii-extensions

My small contribution to the Yii framework community
124 stars 50 forks source link

EFeed: remove prefixing double quotes for Atom feeds #3

Closed boazrymland closed 12 years ago

boazrymland commented 12 years ago

Hi,

This is a small issue: I've used this very nice extension to generate an Atom feed for a site I'm developing. I noticed that prefixing each "description" of an item in the generated feed, there's a double quotes - " - prefixing it. I'm not sure if its needed as I'm not familiar with the Atom (or other feed type) specs but I've found the culprit line in the code and changed it - and it all seems to be fine.

I'll try attaching the diff file after submission of this issue as I don't see any "attach" option at the moment. If it doesn't work, i'll copy paste the single line change to here.

boazrymland commented 12 years ago

Hmm... . isn't there a way to attach a file to an issue? Couldn't see it. So, the affected line is in EFeedItemAtom.php, line 93 (in the current latest version of the extension - v1.3): From:

$element .= '<![CDATA["'.PHP_EOL;

to:

$element .= '<![CDATA['.PHP_EOL;
tonydspaniard commented 12 years ago

Hi... thanks!

Isn't it the way it is on gitHub? https://github.com/tonydspaniard/Yii-extensions/blob/master/extensions/EFeed/EFeedItemAtom.php#L94

Maybe I didn't update the Yii repository with this small fix...

boazrymland commented 12 years ago

Indeed - the Yii repository, v1.3, isn't updated, at least judging by this line... . What a catch! :-)

tonydspaniard commented 12 years ago

Will change the repository whenever i have time... thanks