search

tonyhb / redux-ui

Easy UI state management for react redux
636 stars 58 forks source link

Avoid creating new functions at each render pass. Fixes issue #46 . #47

Open gcazaciuc opened 8 years ago

gcazaciuc commented 8 years ago

There is a problem on how dependencies are setup that cause the CI failures. Tests pass locally. i will have a look at it, also had similar issues like this when first building the project locally

mmiller42 commented 8 years ago

Does this fix the issue with using pure rendering? I'm noticing that every component that uses @ui() in my app re-renders if literally anything changes. I spent some time investigating today and while debugging shouldComponentUpdate I noted that the nextProps.ui is never equal to this.props.ui even when no part of the UI state has been changed.

gcazaciuc commented 8 years ago

Yes it would fix it. In the mean-time I've started out my own local state management solution redux-fractal (https://github.com/gcazaciuc/redux-fractal) which doesn't exhibit this problem.

mmiller42 commented 8 years ago

Awesome! Yeah looks like this project isn't being actively maintained, glad to see you've rolled your own. Thanks!

tonyhb commented 8 years ago

Hey! Apologies for being late, super busy at docker. Lemme take a look and get these merged in if we can :)

On Wed, 5 Oct 2016, 14:01 Matt Miller, notifications@github.com wrote:

Awesome! Yeah looks like this project isn't being actively maintained, glad to see you've rolled your own. Thanks!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tonyhb/redux-ui/pull/47#issuecomment-251798280, or mute the thread https://github.com/notifications/unsubscribe-auth/AASsAXzy7Ys85UNNETYnI0w-m82OImQ-ks5qxBAbgaJpZM4Iz3zW .