search

tonyhb / tectonic

A declarative REST data loader for React and Redux. Docs @
https://tonyhb.github.io/tectonic/
456 stars 31 forks source link

#87 Added fix for not fetching new data when params were changed #103

Closed aindeev closed 7 years ago

aindeev commented 7 years ago
  1. Fixes issue #87, New queries were not being created when the params were changed.
  2. Data merging was not working for array types.

Example where merge would fail: existing data:

{
     "permissions": ["rider", "driver"]
}

update data:

{
     "permissions": ["rider"]
}

The reducer would leave the data in the same state it was before because of the merge

aindeev commented 7 years ago

@tonyhb Could you review this? Thanks :)

tonyhb commented 7 years ago

Yep, I'll carry this PR and fix the two linting issues. Thanks!

aindeev commented 7 years ago

Awesome!

aindeev commented 7 years ago

Also added a fix for #88

tonyhb commented 7 years ago

Thanks! Just pushed a test fix, waiting for CI

tonyhb commented 7 years ago

If this passes we can release the next minor :)

tonyhb commented 7 years ago

@aindeev thanks so much! releasing 2.1.2 in a sec after the next PR passes :)

tonyhb commented 7 years ago

@aindeev merged, 2.1.2 released. thanks again :)