search

tonyhffong / Lint.jl

A lint tool for Julia code
Other
169 stars 33 forks source link

Print non-message to STDERR to avoid confusing emacs. #223

Closed ikirill closed 7 years ago

ikirill commented 7 years ago

This isn't a real issue at all, just a nitpick, but I'm using STDOUT to communicate with a lint process, and printing non-json messages that aren't real lint messages makes the communication a little messier to parse—the output is no longer even valid json.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.7%) to 90.061% when pulling ecbb29ace52aa54940e37f037b6b82bcfffdecd7 on ikirill:fix-println-stderr into 7f311edf7ff7a07acad5a1e79b810aa4e4a82b76 on tonyhffong:master.

TotalVerb commented 7 years ago

LGTM. I think there are other places where we're printing to STDOUT too, but should be printing to STDERR, as noted here, but that can be fixed later. Tell me if you'd like a new tag — otherwise I'll hold off until after n-pass linting is done, as the current master temporarily has a lot more false positives than the latest release.

TotalVerb commented 7 years ago

Since we'll need #224 anyway, I've decided to just make a backport 0.5.1 release, and we may as well include this fix.