search

tonyhffong / Lint.jl

A lint tool for Julia code
Other
169 stars 33 forks source link

Lint fails for files that are `included` by the top-level module file? #248

Closed NHDaly closed 6 years ago

NHDaly commented 6 years ago

~Hi, I don't know if maybe my system is configured weird, but it seems like Lint.jl is unable to follow include statements. Therefore, when linting a file I get all sorts of "use of undeclared symbol" errors. This happens even when using lintpkg, which sounds like it's designed for this sort of thing.~

EDIT: Wait, jk, everything I just said is wrong, sorry. it's been over a week since I first thought about this and I misremembered. Sorry! I'll post a new comment below.

NHDaly commented 6 years ago

Sorry my first message was incorrect.

I'm filing this issue in response to comments I got on this stackoverflow post: https://stackoverflow.com/questions/50083783/julia-recommended-way-to-include-files-list-of-includes-in-top-level-file-or

The actual issue I was having is that when the top-level file in a module includes all the other files in the package, Lint fails on those files since it doesn't have any includes to follow.

Specifically lintfile fails on those files. But actually i just verified that lintpkg works correctly in this situation. My problem is that the Lint integration in Atom seems to call lintfile exclusively, even when editing a Package, so everything showed up as an error incorrectly.

So okay, i think everything is fine here, carry on. Sorry about the Issue!