tonymet / gcloud-go

A faster Google Cloud & Firebase CLI with no dependencies. Reduces CI/CD costs for deployments & storage
GNU General Public License v3.0
4 stars 1 forks source link

add license? also suggestions for Dockerfile / build #1

Closed ldemailly closed 2 weeks ago

ldemailly commented 2 weeks ago

Thanks for doing this

Can you add a license (MIT/bsd/Apache...) ?

For your Dockerfile, have a look at https://laurentsv.com/blog/2024/06/25/stop-the-go-and-docker-madness.html

in particular you don't need to copy certs anymore if you use

import _ "golang.org/x/crypto/x509roots/fallback" // CA bundle for FROM Scratch

And for /tmp you can/should just VOLUME /tmp

cheers

tonymet commented 2 weeks ago

Great tip on both fronts. I think I clobbered the license from earlier. I’ll keep GPL3. I appreciate the support and let me know how you’re using the project.

tonymet commented 2 weeks ago

Excellent guidance and thanks @ldemailly

ldemailly commented 2 weeks ago

most welcome, thanks for the quick updates, a little follow up https://github.com/tonymet/gcloud-go/commit/24a5bbb204da6cd93c2d0bb3202007df426adfd7#commitcomment-148491149

ldemailly commented 2 weeks ago

Also ... you picked GPL... that means it can't be adopted by many companies and also lessen the chance of contributions (or fall back into gcloud offering) - is it a deliberate choice?

tonymet commented 2 weeks ago

Thanks I gave it a thought as I also had those considerations. I prefer encouraging the contributions to stay open. If I see a lot of commercial use cases I’ll think about another licensing approach.

ldemailly commented 2 weeks ago

well the thing is employees approved to work on opensource (already a smaller set) are typically not allowed to touch any gpl code so I don’t think you’ll see much adoption/use case. this being said maybe it can be just maintained by you and used without contributions from others

tonymet commented 2 weeks ago

That’s good guidance. Let’s see how it plays out and I’ll have some good contingencies in place.