tonymorony / komodo_docker_tests

Apache License 2.0
1 stars 2 forks source link

How to activate sapling earlier? #4

Open artemii235 opened 5 years ago

artemii235 commented 5 years ago

Komodod seems to pick 61 block as sapling activation height by default: SET SAPLING ACTIVATION height.61. Setting -ac_sapling=10 doesn't seem to take any effect: curl -v 127.0.0.1:7000 --user test:test --data '{"jsonrpc":"1.0","method":"getblockchaininfo","params":[],"id":"curltest"}'

{
  "result":{
    "chain":"regtest",
    "blocks":124,
    "synced":false,
    "headers":124,
    "bestblockhash":"0d41e93e926649c11e5b710f8ae3899953477fd6706f97464950e7757925f542",
    "difficulty":1.000007093003461,
    "verificationprogress":1,
    "chainwork":"000000000000000000000000000000000000000000000000000000000000084d",
    "pruned":false,
    "commitments":0,
    "valuePools":[
      {
        "id":"sprout",
        "monitored":true,
        "chainValue":0.00000000,
        "chainValueZat":0
      },
      {
        "id":"sapling",
        "monitored":true,
        "chainValue":0.00000000,
        "chainValueZat":0
      }
    ],
    "softforks":[
      {
        "id":"bip34",
        "version":2,
        "enforce":{
          "status":false,
          "found":125,
          "required":750,
          "window":1000
        },
        "reject":{
          "status":false,
          "found":125,
          "required":950,
          "window":1000
        }
      },
      {
        "id":"bip66",
        "version":3,
        "enforce":{
          "status":false,
          "found":125,
          "required":750,
          "window":1000
        },
        "reject":{
          "status":false,
          "found":125,
          "required":950,
          "window":1000
        }
      },
      {
        "id":"bip65",
        "version":4,
        "enforce":{
          "status":false,
          "found":125,
          "required":750,
          "window":1000
        },
        "reject":{
          "status":false,
          "found":125,
          "required":950,
          "window":1000
        }
      }
    ],
    "upgrades":{

    },
    "consensus":{
      "chaintip":"00000000",
      "nextblock":"00000000"
    }
  },
  "error":null,
  "id":"curltest"
}

No upgrades activated at block 124, possible bug in komodod?

artemii235 commented 5 years ago

The problem is asset chains cmd params were not used at all for testnet or regtest modes which is fixed by this PR: https://github.com/jl777/komodo/pull/1697.