ProtoGen - Make include_imports optional and use exe working directory.

[GoogleCodeExporter]

First great work.  Impressed with progress so far.

I've got some annoyances that I would like correct in the root repository
if you agree.

1. I would like --include_imports to not be forced when using
protoc/protogen.  I prefer to create separate files for each proto file
created and I also share common proto files which become a problem when
trying to compile.  (I suppose having a disable option to avoid breaking
existing compiles would also be acceptable but not my preference).

2. Please set the working folder for protoc to run relative to the folder
of the root proto file.  Currently I think it runs from the protoc
directory so includes don't always work as expected.

3. Try to load the xslt files from the protogen executable folder if not
found in the current folder.

I've attached my local changes that do this so you can choose to include
them or not.

Original issue reported on code.google.com by abbott.t...@gmail.com on 18 Mar 2009 at 3:52

Attachments:

• ProtoGen-r242.patch

[GoogleCodeExporter]

Thanks for both the feedback and the contribution; I'll take a look at the 
patch 
later (I'm about to leave the door...) - but I expect the patch is a good idea. 
It 
shouldn't conflict with any of my current changes, so this should be easy.

Thanks again,

Marc

Original comment by marc.gravell on 18 Mar 2009 at 4:28

• Changed state: Accepted
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Applied; thanks for the input - all looks good

Original comment by marc.gravell on 18 Mar 2009 at 9:22

• Changed state: Fixed