tonyp7 / esp32-wifi-manager

Captive Portal for ESP32 that can connect to a saved wireless network or start an access point where you can connect to existing wifis.
MIT License
673 stars 220 forks source link

Move config parameters to init paramters #114

Open lukecyca opened 3 years ago

lukecyca commented 3 years ago

Is your feature request related to a problem? Please describe.

The only way to configure this library is through Kconfig parameters. This is inconvenient if the application code needs to choose these parameters at runtime. This most obvious example is setting the SSID to something device-specific, which is important it there are multiple devices requiring provisioning.

Describe the solution you'd like I would like DEFAULT_AP_SSID, DEFAULT_HOSTNAME, and possibly some others removed from Kconfig and passed to wifi_manager_start().

Describe alternatives you've considered I could edit wifi_manager.h, but that still doesn't allow setting these names dynamically with device-specific identifiers. I could edit the library and maintain a fork, but I prefer to fix this upstream.