search

tonyp7 / esp32-wifi-manager

Captive Portal for ESP32 that can connect to a saved wireless network or start an access point where you can connect to existing wifis.
MIT License
648 stars 214 forks source link

Fix the race condition that happens when in LOAD_AND_RESTORE mode and a user tries to configure a new network. #135

Open mtetreault opened 3 years ago

mtetreault commented 3 years ago

The DNS server is, in some use cases, unwanted. I added the possibility to disable it as required. By default it is enable, so it doesn't change the actual behavior.

My use case is the following. I have a mobile application that configure the wifi and do the pairing with Google IOT. Having the dns server was not useless.

I also moved assets and web files to folders.

mtetreault commented 3 years ago

This PR should fix: Issues: #118 & #109

@hqawasmi & @MPC-BlackBox: Could you please try this. It should fix your issue. Let me know if you still have some issues.

mtetreault commented 3 years ago

@tonyp7: Are you still maintaining this project? Would you have the time to review this?

tonyp7 commented 3 years ago

Hello Matthieu,

I wish I could tell you I was, but as you can clearly see nothing has moved for quite a while. I'm a new dad and moved place so I no longer have my electronics labs for now...

If you would like to be part of the maintenance and auto-accept your PR let me know!

mtetreault commented 3 years ago

Hello Matthieu,

I wish I could tell you I was, but as you can clearly see nothing has moved for quite a while. I'm a new dad and moved place so I no longer have my electronics labs for now...

If you would like to be part of the maintenance and auto-accept your PR let me know!

Congrats on you new born, if I extrapolate, he/she is about a year old right?

If you don't mind, I would love to help you maintain this repository:)