search

tonyp7 / esp32-wifi-manager

Captive Portal for ESP32 that can connect to a saved wireless network or start an access point where you can connect to existing wifis.
MIT License
664 stars 217 forks source link

wifi_manager_destroy never gets called? #15

Closed snahmad closed 6 years ago

tonyp7 commented 6 years ago

That's correct. This function was created as a sanity to clean up properly the memory in case you would like to completely shutdown wifi_manager; but in this implementation the wifi_manager task is always on.

This function is here to help you integrate wifi_manager with your existing codebase.

snahmad commented 6 years ago

ok.

snahmad commented 6 years ago

wifi_config_t* wifi_manager_config_sta is not thread safe. not sure how can i do it in C. I know C++ atomic.

tonyp7 commented 6 years ago

The equivalent in freeRTOS is xSemaphoreTake/xSemaphoreGive. Can you point me to a potential unsafe code location?

snahmad commented 6 years ago

ok, Thanks. While OTA update I need to stop my Http server. that will do trick