tonyp7 / esp32-wifi-manager

Captive Portal for ESP32 that can connect to a saved wireless network or start an access point where you can connect to existing wifis.
MIT License
652 stars 214 forks source link

sockaddr_in sa not used #64

Closed qcarver closed 4 years ago

qcarver commented 4 years ago

https://github.com/tonyp7/esp32-wifi-manager/blob/2871cf1fab3fa5c60c67fcee5c0d0e0c395db34c/src/dns_server.c#L80

Hello, it looks like you grabbed some code that maybe used sa as the bind address to send to and ra as the local address you want to bind to receive on. Implementation in this method though is only using ra. You could scuttle sa if you don't have any plans for it. Thx.

tonyp7 commented 4 years ago

You are right.

Fixed in #83