search

tonyrobots / dcc-qol

DCC Quality of Life Improvements
MIT License
0 stars 0 forks source link

[BUG] Fumble Die not being applied correctly when wearing armor #3

Open archdruid101 opened 1 month ago

archdruid101 commented 1 month ago

I noticed that when a player character is wearing armor the fumble die does not change when you press the "Fumble" Button in the chat dialog. It does not see to matter whether you have armor equipped or not it only rolls the 1d4 for the fumble roll.

  1. Equip armor and weapon
  2. make attack rolls until you get a Nat 1
  3. press the "Fumble" in the chat dialog
  4. See incorrect result in the chat

Screenshots Fumble Roll

Versions Foundry version: V 12 331 DCC system version: V 0.47.0 dcc-qol module version: V 0.1.27

brandon-kohn commented 2 weeks ago

@archdruid101 This bug is due to issues in the dcc system, and then once that is corrected there is an issue or two in this one. Here are some patches to try. The first is for systems/dcc: 0001-Fix-for-fumble-die-not-updating-based-on-armor.patch

The next is for dcc-qol: 0001-Fix-for-wierd-act-and-DCQOLactor-new-instances.patch

archdruid101 commented 2 weeks ago

Thank you, and thank you for all of your hard work on this module. I really makes a difference in my games! 

Yahoo Mail: Search, Organize, Conquer

On Thu, Oct 31, 2024 at 9:56 AM, Brandon @.***> wrote:

@archdruid101 This bug is due to issues in the dcc system, and then once that is corrected there is an issue or two in this one. Here are some patches to try. The first is for systems/dcc: 0001-Fix-for-fumble-die-not-updating-based-on-armor.patch

The next is for dcc-qol: 0001-Fix-for-wierd-act-and-DCQOLactor-new-instances.patch

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

archdruid101 commented 2 weeks ago

This is embarrassing, but I'm still learning the ropes with Fvtt Modules. Where do I place the patches, or how do I install them? Thanks again!

brandon-kohn commented 2 weeks ago

My apologies! I should not have assumed you knew that.

Unzip this one in your FoundryVTT->Data->modules directory:

You can open Windows Explorer and paste the following into the path bar. It will take you to the modules directory.

%USERPROFILE%\AppData\Local\FoundryVTT\Data\modules

dcc-qol.zip

Unzip this one in the FoundryVTT->Data\systems directory:

%USERPROFILE%\AppData\Local\FoundryVTT\Data\systems

dcc.zip

Let me know if you have any other issues and if it works!

archdruid101 commented 2 weeks ago

Thank you! That fixed it!

On Friday, November 1, 2024 at 09:06:18 AM EDT, Brandon Kohn @.***> wrote:

My apologies! I should not have assumed you knew that.

Unzip this one in your FoundryVTT->Data->modules directory: %USERPROFILE%\AppData\Local\FoundryVTT\Data\modules

dcc-qol.zip

Unzip this one in the FoundryVTT->Data\systems directory: %USERPROFILE%\AppData\Local\FoundryVTT\Data\systems

dcc.zip

Let me know if you have any other issues and if it works!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>