tonysamperi / ngx-mat-timepicker

A true material timepicker
https://tonysamperi.github.io/ngx-mat-timepicker
MIT License
114 stars 25 forks source link

[BUG] - Timepicker hover section diverges when selecting time #97

Closed vmuresanu closed 9 months ago

vmuresanu commented 10 months ago

Steps to reproduce the behavior:

  1. Go to Demo page
  2. Open Timepicker
  3. Hover over some hour / minute
  4. Select the hour / minute

Expected behavior Selected hour has to be the same as the "preview / hover" hour.

Actual behavior Selected hour diverges from the "preview / hover" hour.

Screenshots timepicker issue

Versions

Additional context (optional) The selected hour after click coincides with user's mouse. Which means that the problem is in the preview / hover projection.

tonysamperi commented 10 months ago

You're welcome to create a PR if you think this can be managed. That depends on how CSS and Javascript work differently so there's actually no good way of managing the situation. But I think the hovering should be visible only for minutes which are actually printed (0-5-10-15 etc..). I'll do this quick change.

vmuresanu commented 10 months ago

Sorry, but this is the issue from v17.0.0, because in v16.0.0 there was no hovering placeholder. The problem is not in the hour or minute hovering but in the hovering placeholder itself, specifically the fact that it is not aligned and doesn't correspond with the "clicked / selected" value (Please refer to the attached gif in the issue) and furthermore the problem is specifically visible on the minutes counter, because after selecting the hour it immediately opens minute picker thus it's not visible (but still present).

tonysamperi commented 9 months ago

I decided to align the behaviour to the old versions, therefore removing the ripple (cause the old css stopped working after the v17 update, but was actually there).

Solved in v17.0.3.

Cheers