tonysamperi / ngx-popperjs

An Angular 8+ wrapper for @popperjs/core
https://tonysamperi.github.io/ngx-popperjs/
MIT License
65 stars 12 forks source link

Angular 13 support (+ Ivy partial compilation) #16

Closed Yberion closed 2 years ago

Yberion commented 2 years ago

Hello,

I did read the comment saying that we shouldn't ask for "Angular update".

I just have some error/warning when using ngx-popperjs, so this issue is more about a reminder/list of things I detected using ngx-popperjs with Angular 13 (I used --force to for the install) and that will be cool to take a look when you'll have time switching to Angular 13 support.

Warnings when installing (--force):

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: ngx-popperjs@12.2.1
npm WARN Found: @angular/common@13.1.1
npm WARN node_modules/@angular/common
npm WARN   @angular/common@"^13.1.1" from the root project
npm WARN   7 more (@angular/cdk, @angular/flex-layout, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @angular/common@"^12.1.3" from ngx-popperjs@12.2.1
npm WARN node_modules/ngx-popperjs
npm WARN   ngx-popperjs@"^12.2.1" from the root project
npm WARN
npm WARN Conflicting peer dependency: @angular/common@12.2.15
npm WARN node_modules/@angular/common
npm WARN   peer @angular/common@"^12.1.3" from ngx-popperjs@12.2.1
npm WARN   node_modules/ngx-popperjs
npm WARN     ngx-popperjs@"^12.2.1" from the root project
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: ngx-popperjs@12.2.1
npm WARN Found: @angular/core@13.1.1
npm WARN node_modules/@angular/core
npm WARN   @angular/core@"^13.1.1" from the root project
npm WARN   11 more (@angular/animations, @angular/cdk, @angular/common, ...)
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer @angular/core@"^12.1.3" from ngx-popperjs@12.2.1
npm WARN node_modules/ngx-popperjs
npm WARN   ngx-popperjs@"^12.2.1" from the root project
npm WARN Conflicting peer dependency: @angular/core@12.2.15
npm WARN node_modules/@angular/core
npm WARN   peer @angular/core@"^12.1.3" from ngx-popperjs@12.2.1
npm WARN   node_modules/ngx-popperjs
npm WARN     ngx-popperjs@"^12.2.1" from the root project

Warning when generating application bundle (should I make an issue on popperjs/core?):

Generating browser application bundles (phase: setup)...Warning: Entry point 'ngx-popperjs' contains deep imports into 'D:/Git/XXX/node_modules/@popperjs/core/lib/types'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

Compiling the lib (need partial Ivy compilation):

Processing legacy "View Engine" libraries:
- ngx-popperjs [es2015/esm2015] (https://github.com/tonysamperi/ngx-popperjs)
Encourage the library authors to publish an Ivy distribution.

Like I said I'm not asking for anything, it's just a list of things I detected.

Thank you for this lib.

tonysamperi commented 2 years ago

Hi @Yberion thanks for the post, but others had already shared something similar... Anyways I think I won't get any errors when I update dependencies... I will publish the update in the next few days (26-27-28 december).

Happy holidays

tonysamperi commented 2 years ago

Hi @Yberion this should be out tomorrow!

Yberion commented 2 years ago

Hello @tonysamperi thank you for the answer and the fast reaction, this is appreciated!

Don't rush and rest yourself, I'll come back to you if I find any issues after the update (after holidays).

Keep the good work and have a good holidays!

tonysamperi commented 2 years ago

Done 🎉