tonysamperi / ngx-popperjs

An Angular 8+ wrapper for @popperjs/core
https://tonysamperi.github.io/ngx-popperjs/
MIT License
65 stars 12 forks source link

BUG: Cannot find module '@ngx-tonysamperi/dom' #26

Closed habtim closed 2 years ago

habtim commented 2 years ago

Describe the bug When using this library, by npm install @popperjs/core ngx-popperjs --save, @ngx-tonysamperi/dom is not installed as it is not marked as a peer dependency. Therefore, I get an error when consuming NgxPopperjsModule:

Cannot find module '@ngx-tonysamperi/dom' from '../../../../node_modules/ngx-popperjs/fesm2020/ngx-popperjs.mjs'

Workaround: Can be solved by running npm i @ngx-tonysamperi/dom --save

To Reproduce

Expected behavior ngx-tonysamperi/dom should be installed as dependency as well when running npm install @popperjs/core ngx-popperjs --save

Versions

Additional context Seems like I'm the only one with this issue, maybe there is something that I'm missing?

tonysamperi commented 2 years ago

Before dom there was smp-core-utils and it's never been marked as dependency, or peer.

tonysamperi commented 2 years ago

Actually after a second though, smp-core-utils wasn't used, that's why it wasn't a peer. Ok, I'll patch it right away!

tonysamperi commented 2 years ago

@habtim

I moved @ngx-tonysamperi/dom and @popperjs/core to dependencies, so that installing ngx-popperjs will automatically get everything!

v 13.3.0