Closed habtim closed 2 years ago
Before dom there was smp-core-utils and it's never been marked as dependency, or peer.
Actually after a second though, smp-core-utils wasn't used, that's why it wasn't a peer. Ok, I'll patch it right away!
@habtim
I moved @ngx-tonysamperi/dom
and @popperjs/core
to dependencies, so that installing ngx-popperjs
will automatically get everything!
v 13.3.0
Describe the bug When using this library, by
npm install @popperjs/core ngx-popperjs --save
,@ngx-tonysamperi/dom
is not installed as it is not marked as a peer dependency. Therefore, I get an error when consumingNgxPopperjsModule
:Workaround: Can be solved by running
npm i @ngx-tonysamperi/dom --save
To Reproduce
npm install @popperjs/core ngx-popperjs --save
@ngx-tonysamperi/dom
availableNgxPopperjsModule
anywhere in your appExpected behavior
ngx-tonysamperi/dom
should be installed as dependency as well when runningnpm install @popperjs/core ngx-popperjs --save
Versions
Additional context Seems like I'm the only one with this issue, maybe there is something that I'm missing?