search

tonysamperi / ngx-popperjs

An Angular 8+ wrapper for @popperjs/core
https://tonysamperi.github.io/ngx-popperjs/
MIT License
65 stars 12 forks source link

Warning: Entry point 'ngx-popperjs' contains deep imports #3

Closed DerZyklop closed 3 years ago

DerZyklop commented 3 years ago

ngcc gives me this warning:

Warning: Entry point 'ngx-popperjs' contains deep imports into '/Users/nils/S/plano/scheduler.frontend.ng2/node_modules/@popperjs/core/lib/types'. This is probably not a problem, but may cause the compilation of entry points to be out of order.

Someone somewhere said: It is not possible for ngcc to know whether the deep imports are going to be problematic or not, so it is reasonable to give the developer this information so that they can make a decision for themselves.

Thanks for this project 💚

tonysamperi commented 3 years ago

@DerZyklop thank you! I noticed that warning, but luckily it doesn't cause any issues at the moment. A possible alternative would be replicating the models, so we don't need to do the deep imports. But I have a repulsion for "replicate"...so...I'll keep this way until it's really a problem :)