search

tonysamperi / ts-luxon

Typescript based Luxon: ⏱ A library for working with dates and times in TS and JS (immutable)
https://tonysamperi.github.io/ts-luxon
MIT License
13 stars 3 forks source link

Wrong path to typings in 4.3.0 package.json #6

Closed jppresents closed 1 year ago

jppresents commented 1 year ago

In the package json it says:

"typings": "dist/index.d.ts",

but in 4.3.0 the actual index.d.ts has been moved to here:

"dist/lib/index.d.ts"

Without adjusting the package.json information.

This leads to the following error in our builds: error TS7016: Could not find a declaration file for module 'ts-luxon'

tonysamperi commented 1 year ago

mmm very wierd...fixing right away!

tonysamperi commented 1 year ago

ok it's not wrong the path in the index, but it's wrong the output path... Just figuring out why it changed, I don't remember editing the tsconfig... Maybe the version of rollup typescript? 🤔

jppresents commented 1 year ago

What I meant was, that the files have moved and the package.json did not reflect this.

Just as a test to figure out what was going on, I could fix the building, by adding "/lib" to the package.json (in the node_modules directory of the library in our app) - but of course if the files in the dist folder would be in the same path as before, then package.json does not have to change.

We actually fixed our build for the time being by just using the previous version of course.

tonysamperi commented 1 year ago

@jppresents yes. What I meant was that the path shouldn't have changed, so it's a build problem and not a package.json problem :) Anyway fixed in 4.3.2 (still to release)

tonysamperi commented 1 year ago

Fixed in v 4.3.2!