search

tonysimpson / nanomsg-python

nanomsg wrapper for python with multiple backends (CPython and ctypes) should support 2/3 and Pypy
MIT License
381 stars 85 forks source link

testing by py.test #2

Closed kubo39 closed 11 years ago

kubo39 commented 11 years ago

Hi, there

I wrote nn_pair test in this repo using py.test. https://github.com/kubo39/nanomsg-python/tree/pytest

I changed setup.py and LD_LIBRARY_PATH for testing in Python2.7.3 with Ubuntu 12.04. May I ask for your review?

tonysimpson commented 11 years ago

Hi, Sorry for not looking at this earlier.

The library and include path issue, I'd like to know more about, I installed nanomsg into /usr/local and I was able to build the extension without issue but I may have changed my machine config at some point to make this work (I've got a Debian install that's about 2 years old and pretty messed with). Did you run ldconfig after installing nanomsg? I will get my hands on a stock ubuntu install and see what happens.

The test - thanks very much, that's great - I know I should have written some myself by now. I'm going to shortly push some changes which I think put the low level api into a state where I don't think it will need to change much. so it will be a much better target for integration tests, after I've pushed that I'll write some tests and I'd very much appreciate contributions.

Thanks, Tony

kubo39 commented 11 years ago

Thanks for reviewing.

Yes, I run ldconfig after installing nanomsg from source.

tonysimpson commented 11 years ago

Close as now merged - noted compatibility/documentation of lib and include directory requirements on linux and windows still need investigating.