search

tonysimpson / nanomsg-python

nanomsg wrapper for python with multiple backends (CPython and ctypes) should support 2/3 and Pypy
MIT License
382 stars 85 forks source link

Implement nanoconfig support #7

Closed tailhook closed 10 years ago

tailhook commented 10 years ago

Hi,

As discussed in nanomsg mailing list, it's better to support nanoconfig directly by the nanomsg bindings instead of creating separate. The pull request adds just that.

The support of nanoconfig is optional, and is silently disabled if the library is not installed at build time (for the C bindings) or at runtime (for ctypes bindings).

The patch is submitted under MIT license.

tonysimpson commented 10 years ago

Hi Paul, I'll try and find time tomorrow to review and merge this.

tonysimpson commented 10 years ago

Thanks very much Paul, I haven't been able to test this or research it as much as I would like too but it looks good.

I've got quite a few change (sadly only on my machine) which aim at improving accessibility and simplifying distribution, before I push those I will review this properly.

Thanks again.

tailhook commented 10 years ago

The nanoconfig support is tested in my nanomsg integration tests that I'll publish soon, so it should work.

I also want to promote this binding as recommended one for nanomsg, as there are three python bindings with other two mostly dysfunctional.