search

tonythomas01 / gdrive-to-commons

Tool to upload pictures from Google Drive to Wikimedia Commons ⚠️ Moved to Wikimedia Gerrit, so this repo is read only.
https://gdrive-to-commons.toolforge.org/
Apache License 2.0
9 stars 10 forks source link

Added remove button for pictures after selection before uploading #25

Closed dwu1011 closed 4 years ago

tonythomas01 commented 4 years ago

Great stuff. We are almost there. Can you also check if we can disable the sorting on that column too ?

Like this one ? Screenshot 2020-01-11 at 12 09 49

Looks a bit weird if you ask me to sort on a delete action.

tonythomas01 commented 4 years ago

Now that things are working, I see a problem of people clicking "Upload to Commons" button when they have deleted all rows on the list. How about we simply disable the button when there are 0 rows left ?

tonythomas01 commented 4 years ago

I will decline this due to merge conflicts (due to not-running prettier, I guess). However, I have cherry-picked the changes and attributed @dwu1011 on https://github.com/tonythomas01/gdrive-to-commons/commit/3865f0d1a616090ee37d6a1a356047ee87f2d47a

Thank you!