Closed abbasidaniyal closed 4 years ago
See comment: https://phabricator.wikimedia.org/T241425#5989847. Thank you, and lets improve it together!
Sure! 😄
@tonythomas01 I have made the changes mentioned by you. Let me know if I missed out on something!
Okey, I see that after upload it ended up like this:
and the license was not correctly applied. Can you see what went wrong here ? You can look at how data is transmitted from the upload wizard and see why this happened.
Sadly not there yet. As you can see, your changes end up in the comments section on the file. See:
but this is not where we want it actually. For example, look at.: https://commons.wikimedia.org/w/index.php?title=File:2020-04-03_19_41_02_IMG_4695_will_rename_and_categorize_soon.jpg&action=edit
My initial impression is that the information needs to actually go into the description itself. Right now, it goes into the comments, which is not what we want!.
Also, I tried copy pasting the contents you are generating in the comments section to the description anyway to test, and I think it did not work out completely as well. I guess, this might be the problem:
You need \n before each headers in your get_initial_page_text()
But, great progress 👍
The mwclient's code says it has to be in the comments itself. I think we need to remove the description and that should do it.
Solves two phabricator tasks.
T241596
andT241425
. I have followed the media uploader workflow where we can select the license of each image separately.Also implemented the serializer for the license and sending the formatted information to the API.