search

tonythomas01 / gdrive-to-commons

Tool to upload pictures from Google Drive to Wikimedia Commons ⚠️ Moved to Wikimedia Gerrit, so this repo is read only.
https://gdrive-to-commons.toolforge.org/
Apache License 2.0
9 stars 10 forks source link

Tool is not working in internet explorer #44

Open RishikaBhatia17 opened 4 years ago

RishikaBhatia17 commented 4 years ago

The bug The tool is not working in internet explorer as expected.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://tools.wmflabs.org/google-drive-photos-to-commons/
  2. Accept privacy policy and click on the button "Start Uploading"

Expected behavior The user should be redirected to the "Login to Wikimedia Commons" button page

Actual Behavior The user is being redirected to an abnormal user interface where three buttons are being displayed at same time as shown below.

image

Desktop:

abbasidaniyal commented 4 years ago

This is interesting. The page looks like this because there is some JavaScript error as the show/hide section code fails. Can you check and verify what is the console output?

abbasidaniyal commented 4 years ago

Turns out, the error is caused by "`" symbol used for template strings. Internet Explorer does not support template strings. It is working fine on Microsoft Edge, which is the recommended browser by Microsoft. @tonythomas01 Should we refactor the code for Internet Explorer?