Allow user reselect photos from gdrive after deleting all rows from table

tonythomas01 / gdrive-to-commons

Tool to upload pictures from Google Drive to Wikimedia Commons ⚠️ Moved to Wikimedia Gerrit, so this repo is read only.

https://gdrive-to-commons.toolforge.org/

Apache License 2.0

9 stars 10 forks source link

Allow user reselect photos from gdrive after deleting all rows from table #50

Open sonegillis opened 4 years ago

sonegillis commented 4 years ago

When the user select photos from gdrive and later deletes all of them, he still remains on thesame step with the button "Upload to wikimedia commons" and when he clicks on it, an empty filelist is uploaded. Below is an image to show what is explained above gcommons-1

The following are steps taken to solve the issue above

Display to user the view to select photos from google drive when user clears the table with picked files
Edit the call to gapi auth loader to occur only when the oauthToken is not defined to avoid the auth loader called again

sonegillis commented 4 years ago

Ok, thanks for the review. I'm on it

sonegillis commented 4 years ago

Hello @tonythomas01, I have done the changes as you requested. I have also added a modal to display the files that weren't uploaded and the reason for the failed upload. For example I added these photos from my google drive as shown in this image error-msg-3 And after clicking the upload button this is the result error-message We can see that images that weren't uploaded displayed in the modal with the error message for each message while the successful ones are displayed as normal