Add Date Created metadata field for each file

tonythomas01 / gdrive-to-commons

Tool to upload pictures from Google Drive to Wikimedia Commons ⚠️ Moved to Wikimedia Gerrit, so this repo is read only.

https://gdrive-to-commons.toolforge.org/

Apache License 2.0

9 stars 10 forks source link

Add Date Created metadata field for each file #53

Closed RishikaBhatia17 closed 4 years ago

RishikaBhatia17 commented 4 years ago

Users can select the date the image has been created by selecting a date from the datepicker developed.

After the user selects the photo and proceeds to the "Upload to Wikimedia commons" button page, The user can select a date on which the image has been created using the datepicker as shown below.

Screenshot from 2020-03-31 08-01-16

If the user selects a date greater than the today's date, then a alert message appears on the top of the screen saying that "The Date created must be Less than or Equal to today's date" as shown below.

And then the value of the datepicker is again set back to null. After the user selects a suitable date, the datepicker displays the selected date as shown below.

RishikaBhatia17 commented 4 years ago

@tonythomas01, I would request you to review and merge it.

abbasidaniyal commented 4 years ago

@RishikaBhatia17 I have made a get_initial_page_text in my PR #43 . This can serve both the date created field and other parameters as well!

tonythomas01 commented 4 years ago

Hey @RishikaBhatia17, great stuff, but I cannot review your change as there seems to be a merge conflict in this branch. Can you merge master into your branch and update this pull requests ?

git checkout RishikaBhatia17-datepicker
git pull origin HEAD
git checkout master
git pull origin HEAD
git checkout RishikaBhatia17-datepicker
git merge master 

<fix conflicts>
git add <files>
git commit 
git push origin HEAD

? Thank you!

RishikaBhatia17 commented 4 years ago

Hi @tonythomas01 I have updated the datepicker branch as you have instructed above. Hence I would request you to please review my PR and merge it. Thanks!

tonythomas01 commented 4 years ago

Are you sure the merge conflicts are fixed ? I still get the errors though. Let me see if I can fix it.

tonythomas01 commented 4 years ago

This one. Lets see what I can do.

tonythomas01 commented 4 years ago

Sorry, I could not get to fix the conflicts yesterday. @RishikaBhatia17 can you verify this is the case on your machine as well ?

RishikaBhatia17 commented 4 years ago

Hi @tonythomas01 I'm sorry for the merge conflicts in this branch. I have tried to figure them out but i couldn't figure it out and hence I have created a new branch and have sent a new pull request. I would request you to please review that pull request and merge it. Thank you soo much and sorry for the inconvenience created.