search

tonytomov / jqGrid

jQuery grid plugin
www.trirand.com
2.84k stars 1.2k forks source link

Accessibility fixes #1033

Closed eCitiz closed 1 year ago

eCitiz commented 1 year ago

The following changes improves jqGrid accessibility. These changes were driven from accessibility standard (WCAG and RGAA) and tools (Wave Tools and chrome's lighthouse).

If you need further information about why a particular change is necessary for accessibility we can add more details.

tonytomov commented 1 year ago

Thank you very much for this pull request. I found these additions useful. I will check them carefully and will replay ASAP.

Best Regards, Tony

tonytomov commented 1 year ago

Thanks. Accepted

parallels999 commented 1 year ago

Did you forget some display:none here https://github.com/tonytomov/jqGrid/commit/bcdac3955f5180efdfd6990d94fb074bc4ae5c2d? (like https://github.com/tonytomov/jqGrid/pull/1033/commits/aa49c1a6c5b3b4c5e897380f884aeaa9d112e087, https://github.com/tonytomov/jqGrid/pull/1033/commits/98bd4a5adb00418ef8cde3d120f53c1589c73c92) https://github.com/tonytomov/jqGrid/issues/1036