tonytomov / jqGrid

jQuery grid plugin
www.trirand.com
2.84k stars 1.2k forks source link

Fix frozen columns heights with decimals #1039

Closed erikn69 closed 11 months ago

erikn69 commented 1 year ago

image Sometimes tr heigh could be a float, but with $('tr').height() we get an interger, image this causes the frozen columns to become misaligned image Also this happens a lot when using rowspan Any suggestions to improve this?

tonytomov commented 1 year ago

I will hold this PR for now. Frozen columns are very sensitive to any change and I need to look deeper in this. If you believe or not - frozen columns in jqGrid is the most used feature in the last two years.

Best Regards, Tony

erikn69 commented 1 year ago

Frozen columns are very sensitive to any change and I need to look deeper in this.

Yes, I imagine so, there must be some reason that I don't know for the $('tr').height(mh[i]) At the moment I'm testing this on all the custom grids I have, so far no problems, but I don't know all the possible use cases

Also, maybe .first() has better performance than :first-child, should i change it?

erikn69 commented 11 months ago

jQuery bug https://github.com/jquery/jquery/issues/5270, fix will be released on jquery:v3.7.1

tonytomov commented 11 months ago

Thank you very much for the update.

Regards