search

tonytomov / jqGrid

jQuery grid plugin
www.trirand.com
2.85k stars 1.2k forks source link

Problem in the view option of the toolbar (Bootstrap UI) #879

Closed yannniskargakis closed 6 years ago

yannniskargakis commented 7 years ago

It seems that there is a bug in the view functionality of the toolbar. You cannot navigate to the previous object of the table through the arrows by selecting an object from the grid to view. Instead console returns the following error: "Uncaught ReferenceError: npos is not defined"

You can reproduce this bug in your own bootstrap examples: Fuctionality -> Toolbar Settings

tonytomov commented 7 years ago

Please let us know if the fix is ok for you.

yannniskargakis commented 7 years ago

Previous navigator button now works, but for some reason #779 is now back.

tonytomov commented 7 years ago

Hello,

Regarding https://github.com/tonytomov/jqGrid/issues/779 - we an not reproduce the problem. Can you please send us a example with the new build where this happen?

Thank you

yannniskargakis commented 7 years ago

Hello, It is exactly the same problem (Bootsrtap UI / Windows 7 / both Chrome 60 and Firefox 54) as before your fix on 3 Aug (see related comments on #779 ). I have reproduced the problem using my old example on #779 using your latest build.

tonytomov commented 7 years ago

Sorry, I should test your example before to ask. The problem appear to be something like Catch 22 - in your example if you set shrinkToFit : true it will work with the last code correct, but if shrinkToFit false it will work with the old code (before my fix).

Will see how to solve the problem.

Regards Tony

yannniskargakis commented 7 years ago

Unfortunately shrinkToFit : true it's not an option for us, since we have grids with a lot of columns. Please inform me for a fix asap. Thanks

tonytomov commented 7 years ago

Yes, I know. The script should work in both cases - I do not mean "use" shrinkToFit : true when I posted this.

tonytomov commented 7 years ago

Can you please check the new fix. I hope we have fixed the issue this time. Here is the commit https://github.com/tonytomov/jqGrid/commit/c40aeacbf013779fcaaf57cd759f03a38a6d01b7

yannniskargakis commented 7 years ago

It seems that now it's ok. I hope to not bother you again with this issue :-) Thank you for the fix

tonytomov commented 6 years ago

I will close it. If something is not working consider reopen