search

tonytomov / jqGrid

jQuery grid plugin
www.trirand.com
2.84k stars 1.2k forks source link

Does your code handles jquery 3? #939

Closed Koi7 closed 4 years ago

Koi7 commented 5 years ago

This jquery 3 breaking change seems to be still unhandled.

tonytomov commented 5 years ago

Hello,

Can you please let me know where is this inconsistency? Thank you.

Koi7 commented 5 years ago

jqGrid grabs empty values for multiselect and puts them into filter.rules. I believe this is because your code treats empty array as valid value to put into filters. As a result filters are: image

I used the latest version of jqGrid. It didn't resolved the issue. Issue appeared after I updated jquery to 3.x version.

Koi7 commented 5 years ago

Check triggerToolbar function. This function collects search data and doesn't consider case when $('select[multiple]').val() returns - empty array. Breaking change in jquery 3 described here - https://jquery.com/upgrade-guide/3.0/#breaking-change-select-multiple-with-nothing-selected-returns-an-empty-array

tonytomov commented 5 years ago

Thanks. Will check this.

tonytomov commented 5 years ago

Hello,

First of all sorry for delay. I have checked this and it is true. The fix is available in Github. Also fixed the dialogue search too.

Thank you for finding this problem.

If you think that the issue is fixed, please close it.

Best Regards, Tony

Koi7 commented 5 years ago

Hi. I will check this when you release new version of jqGrid. I'm not going to build it by myself.

tonytomov commented 4 years ago

Hope you tested it and is OK. I close it. In case you find something, please reopen the issue