search

tonytomov / jqGrid

jQuery grid plugin
www.trirand.com
2.84k stars 1.2k forks source link

"setCell" method not set cell attributes when nData parameter value is empty string #985

Closed LuckyTil closed 3 years ago

LuckyTil commented 3 years ago

"setCell" method not set cell attributes when nData parameter value is empty string.

Proposed fix: if(nData !== "" || forceupd === true ) { ... } // fix { else { ohtml = tcell; } // fix }

Works for me fine.

tonytomov commented 3 years ago

Thanks. Will test it too.

tonytomov commented 3 years ago

Could not see a problem See:https://github.com/tonytomov/jqGrid/blob/master/js/grid.base.js#L6243 . Which version of jqGrid is used?

LuckyTil commented 3 years ago

Which version of jqGrid is used?

tagged 5.5.4 from Feb.16

module jquery.jqGrid.js ... if(typeof cssp === 'string'){ $(ohtml).addClass(cssp); } else if(cssp) { $(ohtml).css(cssp); } if(typeof attrp === 'object') { $(ohtml).attr(attrp); } ...

LuckyTil commented 3 years ago

Yes, this fixed in 'master'. Thank You.