search

tonytonyjan / jaro_winkler

Ruby & C implementation of Jaro-Winkler distance algorithm which supports UTF-8 string.
MIT License
192 stars 29 forks source link

InvalidWeightError question #37

Closed IlyaOsotov closed 4 years ago

IlyaOsotov commented 4 years ago

I want to know, why you raise an error when weight more than 0.25. If I fork it and change the value, are there some problems with it? I just see python algorithm by my colleagues and they don't have any issues with it.

sabunt commented 4 years ago

@tonytonyjan

tonytonyjan commented 4 years ago

The reason is that If the weight exceeds 0.25, the similarity would become larger than 1, which is not expected.

For detail, please check the formula in the Wiki page:

https://en.wikipedia.org/wiki/Jaro%E2%80%93Winkler_distance#Jaro%E2%80%93Winkler_Similarity

IlyaOsotov commented 4 years ago

Hi @tonytonyjan, Thanks for your quick response. Sorry for disturbing you.