search

tonytonyjan / jaro_winkler

Ruby & C implementation of Jaro-Winkler distance algorithm which supports UTF-8 string.
MIT License
192 stars 29 forks source link

Test with Ruby 2.6 and 2.7 #38

Closed aried3r closed 1 year ago

aried3r commented 4 years ago

This will most certainly fail, so I'm opening this as a draft PR and see where it needs more work.

aried3r commented 4 years ago

Ok, so I think the macOS failures with Ruby 2.1 to 2.3 are unrelated to this PR. It seems a new OpenSSL version was released on Homebrew (1.1, from 1.0) and also the macOS build image on Travis changed since the last test run (check also the available Rubies etc). That seems to be the cause for the failures. I'm not sure which side has to fix it, Travis, RVM, or us. Somebody posted a possible workaround to get an older OpenSSL version installed via homebrew.

To support this theory, you could manually trigger a CI run on Travis and it should also fail in master now.

What do you think? Personally I'd rather not invest too much time getting old Rubies to run on macOS and not test on the latest Ruby versions, 2.6 and 2.7.

Further reading: https://travis-ci.community/t/rvm-install-fails-on-osx-due-to-missing-libraries/5596 https://github.com/rvm/rvm/issues/4819 https://github.com/rvm/rvm/issues/4781 https://github.com/rvm/rvm/issues/4463 https://github.com/Homebrew/homebrew-core/issues/46454

wynksaiddestroy commented 4 years ago

Maybe you should remove all ruby versions < 2.4, because they aren't maintained and supported anymore?

tonytonyjan commented 1 year ago

hi @aried3r, I am sorry for the late reply.

I recently changed CI from travis to github workflow to make maintenance easier. See https://github.com/tonytonyjan/jaro_winkler/commit/5701ef7e76bfe5668486ea7411099ed9210ab671

I removed the support to v2.6 because it has not been supported by core team since 4 years ago.

The GH workfow will test all Ruby versions above v2.7. Though v2.7 has reached end-of-life, three are still 51% of devlopers using it.

I'll close the PR. Let me know if you have any concern, thank you very much!