search

tonytonyjan / jaro_winkler

Ruby & C implementation of Jaro-Winkler distance algorithm which supports UTF-8 string.
MIT License
192 stars 29 forks source link

Create GitHub Actions workflow, remove dups from Travis #40

Closed MSP-Greg closed 1 year ago

MSP-Greg commented 4 years ago

Add a GitHub Actions workflow for testing Ubuntu, macOS, & Windows using Ruby 2.2 thru 2.7.

Ruby master/head fails, see the deprecation warnings shown in the 2.7 tests. I haven't worked with Ruby 1.9.3 for a while, so I'm not comfortable fixing the issue.

More info about Ruby master/2.8/3.0 is at: https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/.

Removed jobs from Travis that are now covered in Actions.

MSP-Greg commented 4 years ago

I believe Actions will not run from a PR until Actions have been run in the main repo. All jobs passed in my fork.

Travis failure is due to an issue install 2.1.10 on macOS?

EDIT: Not really something that should affect choices here, but RuboCop is currently Ruby >= 2.3.

The Actions run in my fork is at: https://github.com/MSP-Greg/jaro_winkler/actions/runs/38350082

tonytonyjan commented 1 year ago

@MSP-Greg Thank you =D