tonyvanriet / lunch-bot

A Slack bot that manages group lunch activity
MIT License
26 stars 5 forks source link

Make the api-token var static #3

Closed the-mikedavis closed 6 years ago

the-mikedavis commented 6 years ago

Remove the :^dynamic quality of api-token (previously *api-token*). This is unnecessary. Just using def ensures that it remains constant, as the api-token should. If the restart method were to be called, the api-token would be re-read, causing repeated IO calls, which are expensive. An api-token should remain constant, so there's no reason to make it dynamic.

tonyvanriet commented 6 years ago

Sorry man, somehow I'm missing notifications for your PRs. I do wanna look into this a little further to understand wtf I was thinking when I originally wrote this. Seems pretty intentional.

Thanks.