search

tonywagner / mlbserver

46 stars 9 forks source link

Conflicting team IDs #36

Open warrentc3 opened 4 months ago

warrentc3 commented 4 months ago

A couple of things I've identified with the m3u downloads.

org filtering (includeOrgs=) to TB, includes Chattanooga Lookouts in return org filtering (includeOrgs=) to KC or CLE, Colorado Rockies is overridden by org minor league affiliate.

team filtering (includeTeams=) returns only specified MLB teams... additionally their affiliates.

warrentc3 commented 3 months ago

also wanted to add that "includeBlackouts" filter affects the team id, thus the tvg-logo

tonywagner commented 3 months ago

Good catch! Org filtering should be fixed in https://github.com/tonywagner/mlbserver/commit/fbae4b8af5b05dd3025e5a0a033fbc7b4c93cd37

Team filtering is expected behavior

If includeBlackouts id/logo is still an issue, please include an example.

warrentc3 commented 3 months ago

will share across sample data and repro steps by tomorrow at the latest. essentially, if i don't include blackouts on m3u, then the team id can get an inconsistent values across various filters. i thought that strange since it's an id field and warrants distinctness.

also, in some of my piddling, i started changing the channel id values to be prefixed with mlb,triplea,doublea,higha,singlea instead of the "mlbtv" prefix for a more qualitative output.

pps, not sure what clients others are using but in emby/channelsdvr, it expects "channel-id" rather than "channelID".