search

tonyxiao / react-native-analytics

React Native wrapper for SegmentIO's Analytics SDK
https://github.com/smore-inc/react-native-segment-io-analytics
MIT License
34 stars 19 forks source link

cannot find <SEGAnalytics.h> with angled brackets, works fine with quotes #1

Closed tijs closed 6 years ago

tijs commented 7 years ago

The library cannot build when trying to import the header file with angled brackets. With quotes this works like a charm though.

gpminsuk commented 7 years ago

@tijs What was your issue? Was it library not being linked? My work around was to add .h and .m files to the project not to Libraries so that the files can be compiled.

tijs commented 7 years ago

@gpminsuk the code as it was gave me a build error in xcode. xcode suggested replacing the angled brackets with quotes, as in my PR. When you do that it builds fine.

gpminsuk commented 7 years ago

@tijs Okay then, it seems not the same issue that I posted in Issues of this project.

Thanks for confirmation! -Minsuk

sesm commented 6 years ago

@tijs this fix is already merged in scope of #14 , I guess we can close this PR.

tijs commented 6 years ago

Sure!