tonyxiao / react-native-analytics

React Native wrapper for SegmentIO's Analytics SDK
https://github.com/smore-inc/react-native-segment-io-analytics
MIT License
34 stars 19 forks source link

iOS installation is step 3 and 4 are wrong #2

Open gpminsuk opened 7 years ago

gpminsuk commented 7 years ago

It took me good hours trying to set up this package on iOS because it seems that the iOS installation steps are copy & paste from it's forked branch. The forked branch instructs to add .xcodeproj to Libraries which is correct because .xcodeproj can be built, but this package instructs to add a directory that contains .h and .m files to Libraries which cannot be built.

The instruction needs to be corrected to add RNSegmentIOAnalytics.h and RNSegmentIOAnalytics.m files directly to the project for build.

sesm commented 6 years ago

It would be even better, if this package supported react-native link

mr-piratman commented 6 years ago

install https://github.com/smore-inc/react-native-segment-io-analytics and use the same package. worked for me