tonyzimbinski / infinite-campus

📚 unofficial API for Infinite Campus written in Node JS
GNU General Public License v3.0
29 stars 11 forks source link

V3.1.0 #11

Closed qwazwsx closed 3 years ago

qwazwsx commented 3 years ago

Relevant Issue: #9

TODO: add param to documentation

Lathryx commented 3 years ago

It worked wonderfully! Well done @qwazwsx!

qwazwsx commented 3 years ago

Thanks for testing, this will be merged soon!

Lathryx commented 3 years ago

Okay, I can add the updated grades part of it as well.

qwazwsx commented 3 years ago

that would be great, thanks!

Lathryx commented 3 years ago

Hmm I haven't done many PRs in my programming experience. Is there a way to add my changes to this pull request? Or should I just make a new PR @qwazwsx?

Lathryx commented 3 years ago

I see I have been assigned, should I be able to edit the file? 🤔

qwazwsx commented 3 years ago

I think so? I'm not really too familiar with branches & PR's aswell. This is really my only ""large"" project I maintain that has other contributors. You might have to make a separate PR and I can merge them later.

qwazwsx commented 3 years ago

Okay, I think I got it, fork the WIP-support-for-mupliple-schools branch, edit it, then make a PR. I'll merge your changes into this branch, and then finally merge the WIP branch to the main branch.

I really should learn the Git CLI...... :laughing:

Lathryx commented 3 years ago

Yes, I had the same thinking, but I think it finally worked. 😅

You should be able to see my PR now, I'm not sure how it's merged though, because after I added my changes to a fork, I hit the "pull request" button and it now seems to have all of our changes in it. We'll see, I guess!

qwazwsx commented 3 years ago

Okay! The changes have been merged. I'll publish 3.1.0 to NPM later today. Thanks so much, @Lathryx for all of your help researching and tracking down this problem. :smile:

Lathryx commented 3 years ago

Great! I'm happy to help! I've had a lot of fun figuring this out with you and getting some experience programming collaboratively! So thank you, as well!

My Discord is Lathryx#2826, so hit me up when you're free! :)