Form ValidationErrors don't work

[ecumene]

For whatever reason, raising a django forms.ValidationError in clean() for any form in details/forms.py does nothing, when it should give you an error on the frontend?

Also, a lot of the validation that goes on in details/views.py does nothing and doesn't work. Take for example like 993 def organization_basic:

if form.is_valid():
   instance = form.save()

#...

   instance.editor_id = request.user.id
   instance.save()

Instance is setup ONLY if form.is_valid(). Yet it's used later when making a new form:

update_tsvector_summary(instance.core_record_type, str(instance.pk))

This sends the frontend back a 500 error, and the backend gets a NoneType has no property... error

Steps to reproduce:

• Open details/contribute/who/
• Fill in required fields
• Set SSF Defined = Yes
• Leave the definition blank
• Click submit,
• Form dies, frontend hangs
• Mitchell Cries

[jackharrhy]

stop cry