search

toofishes / python-pgpdump

PGP packet parser library
Other
55 stars 26 forks source link

pubkey packet parsing #1

Closed bennomadic closed 12 years ago

bennomadic commented 12 years ago

hi! I started implementing pubkey packet parsing. still pending v3, but I think it's basically working.

toofishes commented 12 years ago

This looks pretty awesome, thanks! Is there any way I can ask you to split it into two patches- one for the integer parsing + number parsing changes, and then one to add the new functionality?

bennomadic commented 12 years ago

sure! it's been a good chance to learn "the magical rebase" :) finally it made more sense to me splitting it in these 4 commits, can squash'em onto 2 if you prefer :)