search

toofishes / python-pgpdump

PGP packet parser library
Other
55 stars 26 forks source link

Add entry_point to setup.py #16

Open fawkesley opened 9 years ago

fawkesley commented 9 years ago

This makes pip install pgpdump to install the pgpdump script into the user's $PATH (or .local/bin/)

See https://chriswarrick.com/blog/2014/09/15/python-apps-the-right-way-entry_points-and-scripts/

fawkesley commented 9 years ago

Hi @toofishes is this repo still alive?

toofishes commented 9 years ago

Yes it is! I've been super busy with other projects though so have been neglecting pull requests here. I'll try and take a look at this sometime this week.

On Mar 30, 2015, at 5:12 PM, Paul M Furley notifications@github.com wrote:

Hi @toofishes is this repo still alive?

— Reply to this email directly or view it on GitHub.

fawkesley commented 9 years ago

Totally understand!

You can test locally by doing cd python-pgpdump; pip install --user -e . - you should see the pgpdump script appear in ~/.local/bin/ :)

cicku commented 9 years ago

I'm against this change.

This will conflict with the pgpdump from http://www.mew.org/~kazu/proj/pgpdump/en/ in /usr/bin. I maintain both packages in Fedora.

cicku commented 9 years ago

Also, this is just a "parser library", I found no reason of having executable.

fawkesley commented 9 years ago

@cicku Fair enough about conflicting namespace.

I can't agree that it's just a library though - else why would it offer a main function at all?

cicku commented 9 years ago

My understanding of representing main in the code is for tests ONLY, pgpdump imports and execute tests without side effects.